Changeset 239 for ksyslog

Timestamp:

10/01/13 00:35:34 (12 years ago)

Author:

atzm

Message:

use proc_create_data() instead of proc_create() to avoid race.

File:

• ksyslog/trunk/ksyslog.c (modified) (1 diff)

ksyslog/trunk/ksyslog.c

@@ -451 +451 @@
         }
 
-        ksyslog_proc_queue = proc_create("queue", S_IRUGO,
-                                         ksyslog_procdir, &ksyslog_queue_fops);
+        ksyslog_proc_queue = proc_create_data("queue", S_IRUGO, ksyslog_procdir,
+                                              &ksyslog_queue_fops, &ksyslog_queue.head);
         if (ksyslog_proc_queue == NULL) {
                 remove_proc_entry(ksyslog_procdir->name, ksyslog_procdir->parent);
-                pr_err("proc_create failed\n");
+                pr_err("proc_create_data failed\n");
                 return -ENOMEM;
         }
 
-        ksyslog_proc_queue->data = &ksyslog_queue.head;
         return 0;
 }