Changeset 266

Timestamp:

12/07/13 03:18:24 (10 years ago)

Author:

atzm

Message:

use operator.attrgetter() instead of using cmp

File:

• etherws/trunk/etherws.py (modified) (4 diffs)

etherws/trunk/etherws.py

@@ -50 +50 @@
 import hashlib
 import getpass
+import operator
 import argparse
 import traceback
@@ -188 +189 @@
             self.shut = False
 
-        @staticmethod
-        def cmp_by_number(x, y):
-            return cmp(x.number, y.number)
-
     def __init__(self, fdb, debug):
         self.fdb = fdb
@@ -200 +197 @@
     @property
     def portlist(self):
-        return sorted(self._table.itervalues(), cmp=self.Port.cmp_by_number)
+        return sorted(self._table.itervalues(),
+                      key=operator.attrgetter('number'))
 
     def get_port(self, portnum):
@@ -223 +221 @@
         ports = (self._table[n] for n in portnums)
         ports = (p for p in ports if not p.shut)
-        ports = sorted(ports, cmp=self.Port.cmp_by_number)
+        ports = sorted(ports, key=operator.attrgetter('number'))
 
         for p in ports: